This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Bump httplib2 to 0.12.0#134
Closed
gertvdijk wants to merge 1 commit intogoogle:masterfrom
gertvdijk:bump-httplib2-0.12.0
Closed
Bump httplib2 to 0.12.0#134gertvdijk wants to merge 1 commit intogoogle:masterfrom gertvdijk:bump-httplib2-0.12.0
gertvdijk wants to merge 1 commit intogoogle:masterfrom
gertvdijk:bump-httplib2-0.12.0
Conversation
Notable improvement is the way it looks up a CA cert bundle; this version introduces support for setting a custom CA cert bundle path using the environment variable HTTPLIB2_CA_CERTS.
|
any update on this? |
Author
|
It look like no PRs in this repository are being considered and builds all fail. I see that PRs by members are merged though (#133), so perhaps we should just kindly ask... Hi @KaylaNguyen, could you please review this PR? Thanks. |
|
for now I am building |
Contributor
|
Fixed by #160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable improvement is the way it looks up a CA cert bundle; this version introduces support for setting a custom CA cert bundle path using the environment variable
HTTPLIB2_CA_CERTS.See also httplib2/httplib2#2 (comment).
Assuming that your custom organization CA is added to your system CA bundle already, you could point it to your system bundle with a system-wide environment variable, e.g. on Debian:
(And then re-login to activate the changes.)
The above approach might be a simpler alternative to PRs #89 and #52.