Unpack pointer null state prior to comparison in modeling Abseil's CHECK_NE, in case it is Top#677
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Unpack pointer null state prior to comparison in modeling Abseil's CHECK_NE, in case it is Top#677copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_883112571
branch
2 times, most recently
from
93dc96b to
591a8e2
Compare
copybara-service
bot
force-pushed
the
test_883112571
branch
from
591a8e2 to
0d70def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpack pointer null state prior to comparison in modeling Abseil's CHECK_NE, in case it is Top
CHECK_NE is implemented with
... = absl::...::Check_NEImpl(GetReferenceableValue(lhs), GetReferenceableValue(rhs))as a component.Since
GetReferenceableValue(lhs)only passes along a reference tolhs,we never see the LValueToRValue conversion where we normally do unpacking
for raw pointers. The value is "used" within the other
Check_NEImplhelper function, but that means it is not visible in the current function.
Fix by modeling as if the LValueToRValue happened in the current function.