Cache prewarm base case #9552
Open
Cache prewarm base case #9552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishmgoyal
force-pushed
the
addPrewarmCache2
branch
2 times, most recently
from
3eb2171 to
1bf923f
Compare
rafadevai
reviewed
Jan 5, 2026
anishmgoyal
force-pushed
the
addPrewarmCache2
branch
4 times, most recently
from
d885d66 to
a9669b1
Compare
Contributor
Author
anishmgoyal
commented
Jan 6, 2026
pixelflinger
requested changes
Jan 6, 2026
| } | ||
|
|
||
| const DescriptorSetLayoutArray& getDescriptorSetLayouts() const noexcept { | ||
| inline const DescriptorSetLayoutArray& getDescriptorSetLayouts() const noexcept { |
Collaborator
There was a problem hiding this comment.
don't need the inline keyword here.
Contributor
Author
There was a problem hiding this comment.
i'll remove, but i'm curious - why? this is a single-line, solely-returning function that is non-virtual, defined in a header. am i missing something?
poweifeng
reviewed
Jan 6, 2026
rafadevai
reviewed
Jan 6, 2026
anishmgoyal
force-pushed
the
addPrewarmCache2
branch
from
a9669b1 to
8f199c7
Compare
rafadevai
approved these changes
Jan 6, 2026
anishmgoyal
force-pushed
the
addPrewarmCache2
branch
2 times, most recently
from
938d538 to
7f401d1
Compare
This does not address external samplers yet. This simply handles the case where we want to prewarm a pipeline with the base configuration.
Refactor program's descriptor set layout bindings, clean up some leaking resources
Also, remove unused include
anishmgoyal
force-pushed
the
addPrewarmCache2
branch
from
7f401d1 to
a2f2b4a
Compare
poweifeng
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents hitching for most pipelines, on certain devices with Turnip-based drivers