Fixes "error: templates must have C++ linkage" when compiling with older clang versions. #9562
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der clang versions.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aminya
approved these changes
Dec 30, 2025
z3moon
approved these changes
Jan 2, 2026
Contributor
z3moon
left a comment
z3moon
left a comment
There was a problem hiding this comment.
LGTM based on the discussion in the other PR. But please wait for powei's review.
poweifeng
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the following PR which integrates the upstream include slightly incorrect. #8265 (comment)
Inspecting this a bit closer, I believe the issue really is that including the c++ cstdio header in a block that has c linkage (extern "C") is simply incorrect. That it works with current clang versions seems to me more like a happy accident. Upstream has the include further down the header in the "IMPLEMENTATION" section - at this point the
extern "C"block is already closed so it's not an issue there.The change is trivial and gets the code closer to upstream.