Add graph argument to split, state, graphdef, clone#5258
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Add graph argument to split, state, graphdef, clone#5258copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_869919836
branch
2 times, most recently
from
0df996b to
57aa6bc
Compare
Expose the graph: bool = True argument on the remaining public graph utility functions, allowing users to opt into tree-mode for split, state, graphdef, and clone — not just through transforms like nnx.jit. Tree-mode (graph=False) treats Modules as regular JAX pytrees, avoiding the overhead of the graph protocol. In tree-mode, duplicate Variable instances are not allowed and will raise a ValueError, and shared Ref instances between different parts of the graph are not supported since reference tracking is bypassed entirely. Also parametrizes 9 existing split/merge/flatten tests to run under both graph=True and graph=False, increasing tree-mode test coverage. PiperOrigin-RevId: 869919836
copybara-service
bot
force-pushed
the
test_869919836
branch
from
57aa6bc to
6c4e2ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add graph argument to split, state, graphdef, clone
Expose the graph: bool = True argument on the remaining public graph utility
functions, allowing users to opt into tree-mode for split, state, graphdef,
and clone — not just through transforms like nnx.jit.
Tree-mode (graph=False) treats Modules as regular JAX pytrees, avoiding the
overhead of the graph protocol. In tree-mode, duplicate Variable instances
are not allowed and will raise a ValueError, and shared Ref instances between
different parts of the graph are not supported since reference tracking is
bypassed entirely.
Also parametrizes 9 existing split/merge/flatten tests to run under both
graph=True and graph=False, increasing tree-mode test coverage.