Possible bug fix for thread comment status#23
Open
hazbo wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
As pointed out in google#22, the status for every comment seems to be fyi. This seems to fix that.
|
Thanks! Barbara On Wednesday, December 23, 2015, Harry Lawrence notifications@github.com
|
Contributor
Author
|
This may now be redundant as of #24 |
Collaborator
|
There's the overall status of the entire sub-thread, and the resolved bit for the individual comment. Right now we are only displaying the overall status. I wouldn't want to replace the overall status with the individual comment's status (which is what this PR currently does), but I would not object to displaying both statuses if we can format the output nicely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #22, the status for every comment seems to be fyi.
This seems to fix that.