feat: Add support for Enterprise Team APIs #3861
Conversation
| } | ||
|
|
||
| // EnterpriseTeamCreateOrUpdateRequest is used to create or update an enterprise team. | ||
| type EnterpriseTeamCreateOrUpdateRequest struct { |
There was a problem hiding this comment.
This request struct has one field, sync_to_organizations, which isn’t added yet.
Its description says “Retired” Should I add it or leave it out?
Similarly, the EnterpriseTeam has two fields, sync_to_organizations and group_name, which are marked as Retired.
"group_name": {
"type": [
"string",
"null"
],
"description": "Retired: this field will not be returned with GHEC enterprise teams.",
"examples": [
"Justice League"
]
},
"sync_to_organizations": {
"type": "string",
"description": "Retired: this field will not be returned with GHEC enterprise teams.",
"examples": [
"disabled | all"
]
},
There was a problem hiding this comment.
No, let's please not add a field that the GitHub official docs say is "Retired".
gmlewis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
+ Coverage 92.36% 92.38% +0.02%
==========================================
Files 199 200 +1
Lines 14308 14360 +52
==========================================
+ Hits 13215 13267 +52
Misses 894 894
Partials 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
2 participants
Related: #3860
This PR adds support for Enterprise Teams