feat: Add GitHub App Enterprise perm scope#4343
Open
eroullit wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4343 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 193 193
Lines 19451 19451
=======================================
Hits 18965 18965
Misses 269 269
Partials 217 217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for several new enterprise-related permission fields to the
InstallationPermissionsstruct, along with corresponding accessor methods and unit tests. These changes enhance the codebase to handle a wider range of GitHub App installation permissions, particularly for enterprise features.Creating a installation token yields this output when enterprise-scope permissions are used:
{ "token": "ghs_etcetc", "expires_at": "2026-06-30T14:28:23Z", "permissions": { "enterprise_ai_controls": "read", "enterprise_copilot_metrics": "read", "enterprise_credentials": "read", "enterprise_custom_enterprise_roles": "read", "enterprise_custom_org_roles": "read", "enterprise_custom_properties": "read", "enterprise_custom_properties_for_organizations": "read", "enterprise_organizations": "write", "enterprise_organization_installations": "read", "enterprise_organization_installation_repositories": "read", "enterprise_people": "read", "enterprise_sso": "read", "enterprise_teams": "read" }, "repository_selection": "selected" }Previously, these information were omitted when
go-githubis in used.Enterprise permissions support:
InstallationPermissionsstruct for various enterprise-related permissions, such asEnterpriseAIControls,EnterpriseCopilotMetrics,EnterpriseCredentials, and others. (github/apps.go)github/github-accessors.go)Testing:
github/github-accessors_test.go)