Fix linter hanging in certain situations.#555
Open
sbarzowski wants to merge 1 commit intogoogle:masterfrom
Open
Fix linter hanging in certain situations.#555sbarzowski wants to merge 1 commit intogoogle:masterfrom
sbarzowski wants to merge 1 commit intogoogle:masterfrom
Conversation
We had some accidental aliasing due to shallow copy instead of deep copy. Fixes google#541.
Contributor
|
@sbarzowski this looks useful, shall I try to merge it? |
Contributor
Author
|
Yeah, I need to revive this. I think the travis failure was the primary reason I didn't. |
|
@sbarzowski : Any specific reason why this was never merged ? |
|
We have a rather large code base where this patch also allows us to lint it rather than having it hanging. It certainly would be great it if could get merged, so we don't have to carry the complexity of a custom build ourselves 🙏 |
Collaborator
|
From the comment history this sounds like it would be useful... but I think I'll need to actually understand the linter implementation in more depth to review it properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some accidental aliasing due to shallow copy instead of deep copy.
Fixes #541.