Draft
Conversation
Collaborator
|
Can be done in a separate commit but FYI I can't see the newest screen for M3 Player being used, perhaps what we need is to update to |
Collaborator
|
@yschimke https://github.com/google/horologist/pull/2726/changes#diff-774063993b715c8c878c7cba2d7d71ce0e8694485348ce23548d8015a71299f4 is playlistscreen, I was referring to PlayerScreen in my comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read up on #2643, this is the goal. But maybe guidance has changed since then. So use the compose-preview tool and WEAR_UI.md guidance and update the code to achieve the same. Include before/after screenshots in the PR.
Summary
Migrated the main screens of the media sample app to Material 3 and updated Horologist screens to use
TransformingLazyColumnwhere applicable, following the guidance inWEAR_UI.md.Screenshots
Note
I attempted to upload the screenshots to a gist as requested, but
gh gist createfailed because binary files are not supported. The screenshots are available locally in the scratch directory:/usr/local/google/home/yschimke/.gemini/jetski/brain/c4e5b6e0-a2bd-44f0-8937-8e4715056116/scratch/before_large_round.png/usr/local/google/home/yschimke/.gemini/jetski/brain/c4e5b6e0-a2bd-44f0-8937-8e4715056116/scratch/after_large_round.pngChanges
UampThemeto use Material 3.UampMediaPlayerScreento use M3PlayerScreen.SectionedListandEntityScreeninmedia/ui-material3toTransformingLazyColumn.PlaylistDownloadBrowseScreenandPlaylistDownloadScreenitems with padding.AnimatedMediaControlButtons.build.gradle.kts.toTileColorsusage in tile services.