Fix eraser handling in Ink Stylus Showcase App#722
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix eraser handling in Ink Stylus Showcase App#722copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When multiple erases happen in quick succession, their background geometric computations can sometimes overlap, causing them to accidentally overwrite one another. This CL mitigates this by queuing the eraser strokes per target node, and processing them sequentially. In addition, the stroke segmenting is deferred, and performed once for all erases are handled. PiperOrigin-RevId: 939563424
copybara-service
Bot
force-pushed
the
test_939563424
branch
from
9f85fb3 to
3327069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix eraser handling in Ink Stylus Showcase App
When multiple erases happen in quick succession, their background geometric computations can sometimes overlap, causing them to accidentally overwrite one another. This CL mitigates this by queuing the eraser strokes per target node, and processing them sequentially. In addition, the stroke segmenting is deferred, and performed once for all erases are handled.