Set derivatives to non-zero default values in stroke subtraction.#725
Open
copybara-service[bot] wants to merge 1 commit into
Open
Set derivatives to non-zero default values in stroke subtraction.#725copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_940606592
branch
from
25bcb6a to
bcdd246
Compare
As anti-aliasing is not yet handled, `Subtract` sets anti-aliasing label to `kInterior` to effectively turn off anti-aliasing for new edges. Unfortunately, the zero values for the derivative still causes divisions-by-zero, resulting in artifacts (small cracks in the shape, missing textures, etc.). PiperOrigin-RevId: 940606592
copybara-service
Bot
force-pushed
the
test_940606592
branch
from
bcdd246 to
43c1594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set derivatives to non-zero default values in stroke subtraction.
As anti-aliasing is not yet handled,
Subtractsets anti-aliasing label tokInteriorto effectively turn off anti-aliasing for new edges. Unfortunately, the zero values for the derivative still causes divisions-by-zero, resulting in artifacts (small cracks in the shape, missing textures, etc.).