Support @GenerateObjCCompanion for static @Property methods.#2793
Open
copybara-service[bot] wants to merge 1 commit into
Open
Support @GenerateObjCCompanion for static @Property methods.#2793copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_940556527
branch
from
456e8d9 to
5c90d06
Compare
When @GenerateObjCCompanion generates companion protocol declarations (@protocol FooCompanion), static methods annotated with @Property should be emitted as instance properties rather than class properties (@Property (class, ...)). In TypeDeclarationGenerator, pass whether code is being generated for a Kotlin companion protocol to printPseudoProperty so that the class attribute is omitted when declaring companion protocol properties. Also pass ElementUtil.isStatic(methodElement) to findSetterMethod so setters for static properties are found correctly. PiperOrigin-RevId: 940556527
copybara-service
Bot
force-pushed
the
test_940556527
branch
from
5c90d06 to
0894343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support @GenerateObjCCompanion for static @Property methods.
When @GenerateObjCCompanion generates companion protocol declarations (@protocol FooCompanion), static methods annotated with @Property should be emitted as instance properties rather than class properties (@Property (class, ...)).
In TypeDeclarationGenerator, pass whether code is being generated for a Kotlin companion protocol to printPseudoProperty so that the class attribute is omitted when declaring companion protocol properties. Also pass ElementUtil.isStatic(methodElement) to findSetterMethod so setters for static properties are found correctly.