Tidy up test tags by stripping them in release builds#523
Open
davidjiagoogle wants to merge 1 commit into
Open
Tidy up test tags by stripping them in release builds#523davidjiagoogle wants to merge 1 commit into
davidjiagoogle wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the standard testTag modifier with a custom debugTestTag extension across several modules to ensure test tags are stripped in release builds. The review feedback identifies a violation of the DRY principle and namespace pollution, as the extension is duplicated across four modules and defined under a third-party package namespace; consolidating it into a shared module under a project-specific package is recommended. Additionally, a redundant testTag remains inside a semantics block in QuickSettingsComponents.kt, which defeats the purpose of the release-build stripping and should be removed.
Introduced debugTestTag extension on Modifier to replace testTag. In debug builds, it behaves normally. In release builds, it is inlined as a no-op to optimize compilation and execution overhead. Updated UI components across all screens to use debugTestTag.
davidjiagoogle
force-pushed
the
david/stripTestTags
branch
from
b0904bc to
c68b543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced
debugTestTagextension onModifierto replacetestTag.In debug builds, it behaves normally.
In release builds, it is inlined as a no-op to optimize compilation and execution overhead.
Updated UI components across all screens to use
debugTestTag.