Skip to content

Add per-port domain override#433

Open
es3n1n wants to merge 1 commit intogoogle:v1from
es3n1n:es3n1n/domains
Open

Add per-port domain override#433
es3n1n wants to merge 1 commit intogoogle:v1from
es3n1n:es3n1n/domains

Conversation

@es3n1n
Copy link

@es3n1n es3n1n commented Mar 3, 2026

this pr adds a new domain field to PortSpec that lets each port override its dns subdomain prefix (port.Domain + "." + domainName instead of the default {challengeName}-web.{domainName} or {challengeName}.{domainName})

also fixes the NodePort service deduplication to check the resolved service port instead of the raw port.Port field (please let me know if you want this to be in a separate pr)

(external-dns.go was edited by go fmt during make build so I assumed it will be fine if i attach it to this pr)

@google-cla
Copy link

google-cla bot commented Mar 3, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant