Skip to content

style: Special case IntOrBool 1 and 0 values to yes and no.#117

Merged
JeffFaer merged 1 commit intomainfrom
jfaer/newline_separated
Mar 9, 2026
Merged

style: Special case IntOrBool 1 and 0 values to yes and no.#117
JeffFaer merged 1 commit intomainfrom
jfaer/newline_separated

Conversation

@JeffFaer
Copy link
Collaborator

@JeffFaer JeffFaer commented Mar 9, 2026

No description provided.

@JeffFaer JeffFaer requested a review from KatrinaHoffert March 9, 2026 16:43
@JeffFaer JeffFaer enabled auto-merge (squash) March 9, 2026 16:43
Copy link
Member

@KatrinaHoffert KatrinaHoffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be still a smidge confusing because I'm guessing it means that formatValue can still be inconsistent (i.e., user specified "0" but it becomes "false"), but probably less likely to be inconsistent than before? I assume that inconsistency is what you're trying to fix.

@JeffFaer JeffFaer merged commit b78ccf3 into main Mar 9, 2026
9 checks passed
@JeffFaer JeffFaer deleted the jfaer/newline_separated branch March 9, 2026 17:33
@JeffFaer
Copy link
Collaborator Author

but probably less likely to be inconsistent than before? I assume that inconsistency is what you're trying to fix.

Yeah that was my thought process as well. Theoretically we could track whether the user specified an int or a bool and propagate that back to them, but that seems more complexity than it's worth

I would imagine that newline_separated=yes is more common than newline_separated=1, and users (or just me) will be less surprised by seeing newline_separated=yes in debug output as opposed to newline_separated=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants