Fix and operator to return operands, not bools#90
Open
theadamdanielsson wants to merge 1 commit into
Open
Conversation
`and` coerced its result to a bool instead of returning the operand, unlike `or`. This breaks the `(cond and x) or y` value idiom, which renders True/False instead of x/y. Mirror the `or` branch so `and` matches Jinja2/Python short-circuit semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
andcoerces its result to a bool instead of returning the operand —oralready does the right thing, so this just makesandmatch it (and Jinja2/Python).The
(cond and x) or yternary idiom is where this bites. Boolean context (if a and b) is unaffected, which is why it's gone unnoticed. Fix mirrors theorbranch. Added a syntax test for the value-context case; the rest of the suite is unchanged (locally the only failures are the gated meta-llama fetches returning 401s, unrelated to this).