Skip to content

Update console dum and user history sql queries to prevent memory leaks#3128

Open
ptkach wants to merge 1 commit into
google:masterfrom
ptkach:consoleMemoryOptimization
Open

Update console dum and user history sql queries to prevent memory leaks#3128
ptkach wants to merge 1 commit into
google:masterfrom
ptkach:consoleMemoryOptimization

Conversation

@ptkach

@ptkach ptkach commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@ptkach ptkach requested a review from gbrodman June 30, 2026 18:57

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ptkach).


core/src/main/java/google/registry/ui/server/console/ConsoleDumDownloadAction.java line 119 at r1 (raw file):

                      .createNativeQuery(SQL_TEMPLATE, String.class)
                      .setParameter("registrarId", registrarId)
                      .setParameter("now", clock.now())

oh yay, because we use the built-in java instant i think this works now? That's why we had to use the string replacement before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants