Skip to content

chore: update unsafe plugin warning message#2704

Closed
cuixq wants to merge 3 commits intogoogle:mainfrom
cuixq:warning
Closed

chore: update unsafe plugin warning message#2704
cuixq wants to merge 3 commits intogoogle:mainfrom
cuixq:warning

Conversation

@cuixq
Copy link
Copy Markdown
Contributor

@cuixq cuixq commented Apr 8, 2026

The previous warning message was a bit confusing if there is no relevant manifests that the mentioned plugin will run on.

@cuixq cuixq marked this pull request as ready for review April 8, 2026 23:32
@cuixq cuixq requested review from G-Rath, Ly-Joey and another-rex April 8, 2026 23:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.29%. Comparing base (800145f) to head (d3ca4ce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
- Coverage   71.60%   71.29%   -0.32%     
==========================================
  Files         164      164              
  Lines       12090    12090              
==========================================
- Hits         8657     8619      -38     
- Misses       2805     2836      +31     
- Partials      628      635       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq
Copy link
Copy Markdown
Contributor Author

cuixq commented Apr 13, 2026

Going to move this warning message to enricher itself so it will only show up when the specific plugin is run.

@cuixq cuixq closed this Apr 13, 2026
@cuixq cuixq deleted the warning branch April 13, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants