Skip to content

refactor: remove redundant internal packages migrated to osv-scalibr#2720

Merged
cuixq merged 4 commits intogoogle:mainfrom
cuixq:cleanup
Apr 14, 2026
Merged

refactor: remove redundant internal packages migrated to osv-scalibr#2720
cuixq merged 4 commits intogoogle:mainfrom
cuixq:cleanup

Conversation

@cuixq
Copy link
Copy Markdown
Contributor

@cuixq cuixq commented Apr 14, 2026

#2675

This PR cleans up the codebase by removing internal implementations that have been migrated to osv-scalibr.

  • Deleted the following packages and their associated testdata:
    • internal/datasource
    • internal/resolution
    • internal/remediation
    • internal/tui
    • internal/utility/maven
  • Moved func NewInsightsAlphaClient from internal/datasource to internal/depsdev.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.72%. Comparing base (f6c921c) to head (ab4bb65).

Files with missing lines Patch % Lines
internal/depsdev/depsdev.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
+ Coverage   71.44%   79.72%   +8.28%     
==========================================
  Files         164      117      -47     
  Lines       12075     8016    -4059     
==========================================
- Hits         8627     6391    -2236     
+ Misses       2829     1248    -1581     
+ Partials      619      377     -242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq cuixq marked this pull request as ready for review April 14, 2026 05:37
@cuixq cuixq requested a review from michaelkedar April 14, 2026 05:37
Copy link
Copy Markdown
Member

@michaelkedar michaelkedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love deleting code 🙂

@cuixq cuixq merged commit 99470e9 into google:main Apr 14, 2026
35 of 38 checks passed
@cuixq cuixq deleted the cleanup branch April 14, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants