[QwixStructuralInterception] Enable structural binding for PrimitiveBindOp to support transpose op removal and allow for robust ODML metadata propagation.#211
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_867809631
branch
3 times, most recently
from
c737279 to
cc4b174
Compare
…indOp to support transpose op removal and allow for robust ODML metadata propagation. This CL refactors the interception logic to support multiple interceptors (e.g., structural + numerical) and disables JIT for primitive binding. This enables catching all transpose operations at the primitive level, eliminating the maintenance burden of manually mapping every transpose op variant. Key changes: - interception.py: Added support for interceptor stacking. Replaced hardcoded JIT disabling with a generic PRIMITIVE_BIND_KEY check. - model.py: Unified Linen/NNX interception in _apply_interceptors, applying structural then numerical interceptors. - odml.py & odml_ops.py: Configured ODML providers to return multiple interceptors, including PrimitiveBindOp. PiperOrigin-RevId: 867809631
copybara-service
bot
force-pushed
the
test_867809631
branch
from
cc4b174 to
b3c4eb8
Compare
copybara-service
bot
changed the title
jax.core.Primitive.bind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixStructuralInterception] Enable structural binding for PrimitiveBindOp to support transpose op removal and allow for robust ODML metadata propagation.
This CL refactors the interception logic to support multiple interceptors (e.g., structural + numerical) and disables JIT for primitive binding. This enables catching all transpose operations at the primitive level, eliminating the maintenance burden of manually mapping every transpose op variant.
Key changes:
Added support for interceptor stacking.
Replaced hardcoded JIT disabling with a generic PRIMITIVE_BIND_KEY check.
Unified Linen/NNX interception in _apply_interceptors, applying structural then numerical interceptors.
Configured ODML providers to return multiple interceptors, including PrimitiveBindOp.