-
Notifications
You must be signed in to change notification settings - Fork 330
Add support for repeatable feature tours. #12022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Storybook is ready:
|
|
Size Change: +880 B (+0.04%) Total Size: 2.23 MB ℹ️ View Unchanged
|
|
Build files for b6d7b49 have been deleted. |
| steps, | ||
| tourID, | ||
| gaEventCategory, | ||
| isRepeatable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While implementing this issue, I realised it would be more consistent to provide isRepeatable as a prop, rather than retrieving the current tour via getCurrentTour() as specified in the IB.
nfmohit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist