Skip to content

Conversation

@jimmymadon
Copy link
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Storybook is ready:

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Size Change: +226 B (+0.01%)

Total Size: 2.23 MB

ℹ️ View Unchanged
Filename Size Change
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 20 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 20 B 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.88 kB 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.07 kB 0 B
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.88 kB 0 B
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5.07 kB 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.js 20 B 0 B
./dist/assets/blocks/sign-in-with-google/index.js 18.6 kB 0 B
./dist/assets/css/googlesitekit-admin-css-********************.min.css 65.2 kB 0 B
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.7 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.6 kB 0 B
./dist/assets/js/146-********************.js 963 B 0 B
./dist/assets/js/201-********************.js 2.85 kB 0 B
./dist/assets/js/314-********************.js 100 kB 0 B
./dist/assets/js/315-********************.js 3.08 kB 0 B
./dist/assets/js/379-********************.js 3.7 kB 0 B
./dist/assets/js/590-********************.js 1.89 kB 0 B
./dist/assets/js/640-********************.js 2.36 kB 0 B
./dist/assets/js/909-********************.js 1.01 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 475 B 0 B
./dist/assets/js/googlesitekit-activation-********************.js 24.6 kB 0 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 56.3 kB 0 B
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB 0 B
./dist/assets/js/googlesitekit-api-********************.js 7.88 kB 0 B
./dist/assets/js/googlesitekit-block-tracking-********************.js 5.49 kB 0 B
./dist/assets/js/googlesitekit-components-********************.js 5.81 kB 0 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 1.7 kB 0 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js 6.95 kB 0 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 1.51 kB 0 B
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.4 kB 0 B
./dist/assets/js/googlesitekit-datastore-ui-********************.js 7.1 kB 0 B
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.7 kB 0 B
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 65.6 kB +88 B (+0.13%)
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.77 kB 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 745 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.77 kB 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.69 kB 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.72 kB 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.79 kB 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.14 kB 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.77 kB 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 6.16 kB 0 B
./dist/assets/js/googlesitekit-key-metrics-setup-********************.js 50.1 kB 0 B
./dist/assets/js/googlesitekit-main-dashboard-********************.js 137 kB +72 B (+0.05%)
./dist/assets/js/googlesitekit-metric-selection-********************.js 54.8 kB 0 B
./dist/assets/js/googlesitekit-modules-********************.js 19.9 kB 0 B
./dist/assets/js/googlesitekit-modules-ads-********************.js 48.4 kB 0 B
./dist/assets/js/googlesitekit-modules-adsense-********************.js 134 kB 0 B
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 189 kB 0 B
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.3 kB 0 B
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.7 kB 0 B
./dist/assets/js/googlesitekit-modules-search-console-********************.js 65.2 kB 0 B
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.7 kB 0 B
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.2 kB 0 B
./dist/assets/js/googlesitekit-notifications-********************.js 63.2 kB 0 B
./dist/assets/js/googlesitekit-polyfills-********************.js 230 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 128 kB +66 B (+0.05%)
./dist/assets/js/googlesitekit-splash-********************.js 75.2 kB 0 B
./dist/assets/js/googlesitekit-user-input-********************.js 48.2 kB 0 B
./dist/assets/js/googlesitekit-vendor-********************.js 328 kB 0 B
./dist/assets/js/googlesitekit-widgets-********************.js 104 kB 0 B
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.8 kB 0 B
./dist/assets/js/runtime-********************.js 1.92 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Build files for eb7f3ff have been deleted.

@tofumatt tofumatt changed the base branch from develop to main January 6, 2026 00:36
@tofumatt tofumatt merged commit 3bbed4f into main Jan 6, 2026
25 of 26 checks passed
@tofumatt tofumatt deleted the enhancement/11459-add-loading-spinner-to-notice-ctas branch January 6, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants