Skip to content

Add file write/read verification test to HostMemoryAllocatorTest #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add file write/read verification test to HostMemoryAllocatorTest #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 50 additions & 2 deletions tpu_raiden/core/host_memory_allocator_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
#include "tpu_raiden/core/host_memory_allocator.h"

#include <cstdint>
#include <cstdio>
#include <cstring>
#include <fstream>
#include <string>
#include <vector>

#include "xla/tsl/platform/statusor.h"
#include "xla/tsl/platform/test.h"
Expand All @@ -24,8 +28,6 @@
namespace tpu_raiden {
namespace {

using ::absl_testing::IsOk;

TEST(HostMemoryAllocatorTest, FallbackAllocationWithoutClient) {
TF_ASSERT_OK_AND_ASSIGN(auto allocator, HostMemoryAllocator::Create(nullptr));

Expand Down Expand Up @@ -77,5 +79,51 @@ TEST(HostMemoryAllocatorTest, AllocationWithTpuClient) {
}
}

TEST(HostMemoryAllocatorTest, FileWriteReadVerifyWithTpuClient) {
TF_ASSERT_OK_AND_ASSIGN(TpuPjrtManager * manager,
TpuPjrtManager::GetDefault());
ASSERT_NE(manager->client(), nullptr);

TF_ASSERT_OK_AND_ASSIGN(auto allocator,
HostMemoryAllocator::Create(manager->client()));

// Allocate 10MB
const size_t kSize = 10 * 1024 * 1024;
TF_ASSERT_OK_AND_ASSIGN(HostBufferAllocation alloc,
allocator->Allocate(kSize));
EXPECT_NE(alloc.ptr, nullptr);
EXPECT_EQ(alloc.size, kSize);
EXPECT_NE(alloc.owner, nullptr);

// Fill buffer with a pattern
for (size_t i = 0; i < kSize; ++i) {
alloc.ptr[i] = static_cast<uint8_t>(i % 256);
}

// Write to /tmp/
std::string filename = "/tmp/host_memory_allocator_test_file_10mb.bin";
{
std::ofstream ofs(filename, std::ios::binary);
ASSERT_TRUE(ofs.is_open());
ofs.write(reinterpret_cast<const char*>(alloc.ptr), kSize);
ASSERT_TRUE(ofs.good());
}

// Read back into a different buffer to verify
std::vector<uint8_t> read_buffer(kSize);
{
std::ifstream ifs(filename, std::ios::binary);
ASSERT_TRUE(ifs.is_open());
ifs.read(reinterpret_cast<char*>(read_buffer.data()), kSize);
ASSERT_TRUE(ifs.good());
}

// Validate contents
EXPECT_EQ(std::memcmp(alloc.ptr, read_buffer.data(), kSize), 0);

// Clean up
std::remove(filename.c_str());
}

} // namespace
} // namespace tpu_raiden