fix(transfers): min_transfer_time is conditionally required for timed transfers#640
Open
rudiejd wants to merge 1 commit into
Open
fix(transfers): min_transfer_time is conditionally required for timed transfers#640rudiejd wants to merge 1 commit into
rudiejd wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Problem
The wording of
min_transfer_timevaguely indicates that it might be required for timed transfers (transfer_type= 2). This is the interpretation that some consumers, such as Google, accept, but the column is specified as optional in the spec so the requirement is not a formal one.Proposed Solution
Make
min_transfer_timeconditionally required for timed transfers.Type of change
GTFS Schedule
GTFS Realtime
Additional Information
MBTA had our feed rejected by Google because this requirement was not met. The requirement seems reasonable, but it is not specified strongly enough so as to be an unambiguous rule.
Checklist