Add text-backbone support for Gemma 4 12B and 12B-it#1570
Open
deep-diver wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
9f259ee to
490a1b6
Compare
Collaborator
|
@deep-diver thanks a lot for adding the support. A followup question: how is the MMLU result being measured? is it using Tunix's sampler? Meanwhile, can you also include a sampling output in the test plan? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Tunix text-backbone support for:
google/gemma-4-12bgoogle/gemma-4-12b-itIt adds Gemma 4 12B model configs, registry entries, and safetensors mapping tests based on the existing Gemma 4 implementation.
This change covers the Gemma 4 12B language-model/text backbone only. Full Gemma 4 Unified multimodal image/audio/video support is out of scope.
What Changed
ModelConfig.gemma4_12b()ModelConfig.gemma4_12b_it()google/gemma-4-12bgoogle/gemma-4-12b-itImplementation Notes
The 12B config follows the HF
google/gemma-4-12B-ittext config:k_eq_vValidation
Local tests:
Result:
Registry / naming / AutoModel tests:
GPU validation on A100-80GB:
google/gemma-4-12B-itsafetensors checkpoint in Tunix/JAXtunix.generate.samplerSelected parity evidence:
500-sample MMLU-Pro-style parity probe:
Note: this is a benchmark-style parity probe, not an official MMLU-Pro benchmark reproduction.
Generation smoke tests:
Tunix generated coherent text outputs and matched HF parsed outputs on representative text-only samples.
Scope
This PR does not add full Gemma 4 Unified multimodal support.
The current Tunix Gemma4 model path supports text tokens only. The unified checkpoint contains multimodal weights such as:
These are intentionally out of scope for this PR and are not loaded by the current text-backbone implementation.