Guard duplicate-key check and write in safetensors loader with a lock#1627
Open
AMR5210 wants to merge 2 commits into
Open
Guard duplicate-key check and write in safetensors loader with a lock#1627AMR5210 wants to merge 2 commits into
AMR5210 wants to merge 2 commits into
Conversation
Added a lock to prevent race conditions when checking for duplicate keys in loaded tensors.
Add a test to verify that loading a model raises an error on duplicate keys.
Author
|
Opened #1627 to fix this. The fix adds a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1259
This fixes a TOCTOU race in
load_and_create_model_orig(
tunix/models/safetensors_loader.py).process_keyruns across aThreadPoolExecutor(max_workers=os.cpu_count()), but the duplicate-key checkif jax_key_mapped in file_loaded_tensorsand the following write were notprotected by a lock. Two threads whose source keys map to the same jax key can
both pass the check before either writes, so the second silently overwrites the
first and the intended
ValueErrornever fires. The model then loads withincorrect weights and no error.
The fix adds a
dict_lockand wraps only the check and write in it. The tensorread, transform, and dtype cast stay outside the lock, so loading remains
parallel with no meaningful speed impact.
Reference
Colab Notebook
N/A. This is a bug fix to existing loading code and adds no new API.
Checklist