Fix example max_steps calculations#1629
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the example launch scripts that were computing
max_stepsasbatch_size * num_batches * num_train_epochs * train_fraction.Those scripts now compute
max_stepsfromnum_batches * num_train_epochs * train_fraction, which matches the CLI's step-based semantics. Sincewarmup_stepsanddecay_stepsare derived frommax_stepsin these scripts, they now stay aligned as well.Why
tunix.cli.grpo_maintreatsmax_stepsas optimizer/training steps and caps it againstnum_batches * num_train_epochs * train_fraction.A handful of example scripts were multiplying by
batch_size, which effectively turned the value into a sample count. That could overrun training bybatch_sizex and skew warmup/decay schedules relative to the actual number of optimizer steps.Impact
The affected examples now match the repo's documented and implemented
max_stepsbehavior.Validation
rg -n '\$batch_size \* \$num_batches \* \$num_train_epochs \* \$train_fraction' . -g '*.sh'bash -non the 8 updated scriptsgit diff --check