Fix beam search test helper indexing#1630
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This fixes
_check_content_equal_per_beam()intests/generate/beam_search_test.pyso it iterates bybatch_idxandbeam_idxwhen comparing replicated beam content back to the original batch entries.It also adds a focused regression test that exercises both 2D beam-expanded content and 1D beam-expanded flags.
Why
The helper previously stepped
ibybeam_sizeand then indexedbeam_content[i * beam_size]andoriginal_content[i].With
batch_size=2andbeam_size=2, the second loop iteration reachedbeam_content[4]andoriginal_content[2], which are both out of bounds.Impact
The beam search tests now validate per-batch/per-beam replication correctly, and the regression test covers the path that used to go out of bounds.
Validation
uv run --extra test python tests/generate/beam_search_test.py