Stop sampler decode one step earlier#1631
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This stops
tunix.generate.sampler.Sampler._decode_fn()at the last writable token slot instead of allowing one extra decode iteration after prefill.It also adds a regression test that exercises
max_generation_steps=1and verifies that_decode_fn()leaves the sampler state unchanged after prefill has already produced the single generated token.Why
init_sample_state()startsdecoding_stepat the last prompt token._prefill_fn()immediately calls_sample(), which writes the first generated token atdecoding_step + 1and advances the step.That means by the time decode starts, prefill has already consumed one generation step. The old decode condition still allowed another iteration when
decoding_step == total_sampling_steps - 1, even though the next write would targetdecoding_step + 1beyond the intended writable range.Impact
max_generation_steps=1now performs exactly one generation step instead of running an extra decode iteration. The same boundary is respected for longer generations as well.Validation
uv run --extra test python tests/generate/sampler_test.py