Verify model supports segment-ids#1632
Open
yatlas20098 wants to merge 2 commits into
Open
Conversation
yatlas20098
commented
Jun 30, 2026
Collaborator
- I have added all the necessary unit tests for my change.
- I have verified that my change does not break existing code and all unit tests pass.
- I have added all appropriate doc-strings/documentation.
- My PR is based on the latest changes of the main branch (if unsure, rebase the code).
- I have signed the Contributor License Agreement.
- I have followed Contribution Guidelines.
tianshub
reviewed
Jun 30, 2026
| segment_positions, | ||
| ) | ||
|
|
||
| try: |
Collaborator
There was a problem hiding this comment.
worth to move it out as a helper function and cache it? so it's not part of the core logic.
e.g.
@functools.cache
def call_contains(model, target_arg):
...
Collaborator
Author
There was a problem hiding this comment.
I've implemented caching but key'd it based on the model type instead of the model instance. Since nnx.merge constructs the model instance during each computation step, caching the model instance directly would result in zero hits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.