Improve the COMPACT mode in mesh creation.#1641
Open
wang2yn84 wants to merge 1 commit into
Open
Conversation
wang2yn84
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2 and
tianshub
as code owners
wang2yn84
force-pushed
the
lance-fix-compact
branch
from
52c4a45 to
056a29d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the COMPACT mode in mesh creation, it will find the best shape that leaves fewest remainders. Without this PR, both COMPACT mode and PERFORMANCE mode finds the most cubicle shape from the available regions.
Reference
Colab Notebook
Checklist