feat: add client logging support for sync gRPC #2284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
force-pushed
the
add-debug-logging-for-sync-grpc
branch
2 times, most recently
from
5765247 to
77f47ee
Compare
product-auto-label
bot
added
size: xl
ohmayr
force-pushed
the
add-debug-logging-for-sync-grpc
branch
from
f6392c9 to
30a2939
Compare
vchudnov-g
reviewed
Dec 10, 2024
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Looks good. One non-trivial question.suggestion about the accessor.
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
...on/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc.py
Outdated
Show resolved
Hide resolved
...on/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc.py
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| self._grpc_channel = self._base_channel | ||
| if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(std_logging.DEBUG): # pragma: NO COVER |
Contributor
There was a problem hiding this comment.
I suggest checking here whether any logging levels are handled at all, so using either std_logging.NOTSET or the next highest priority, the numeric 1 (ref)
...on/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc.py
Outdated
Show resolved
Hide resolved
vchudnov-g
requested changes
Dec 11, 2024
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: xl
product-auto-label
bot
added
size: l
vchudnov-g
reviewed
Dec 11, 2024
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
LGTM. I can do a final pass once you have the if/elif stuff down.
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Outdated
Show resolved
Hide resolved
vchudnov-g
approved these changes
Dec 11, 2024
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Show resolved
Hide resolved
vchudnov-g
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excludes support for mixins and streaming calls.