Skip to content

fix: missing auth header in impersonated service account credentials #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BSick7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: missing auth header in impersonated service account credentials #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/googleauth/impersonated_service_account.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,7 @@ def fetch_access_token! _options = {}
# @private
# @return [Hash] The authorization header with the source credentials' token
def prepare_auth_header
auth_header = {}
@source_credentials.updater_proc.call auth_header
auth_header
@source_credentials.updater_proc.call {}
Copy link

@arenclissold arenclissold Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For us we needed to keep defining the auth_header here. The fix seems to be removing auth_header from the return

def prepare_auth_header
  auth_header = {}
  @source_credentials.updater_proc.call auth_header
end

end

# Makes the HTTP request to the impersonation endpoint.
Expand Down
Loading