fix: make header names python-safe#592
Open
saurabhkoshatwar wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: make header names python-safe#592saurabhkoshatwar wants to merge 1 commit intogoogleapis:mainfrom
saurabhkoshatwar wants to merge 1 commit intogoogleapis:mainfrom
Conversation
3 tasks
Contributor
|
/gcbrun |
Contributor
|
Thanks for the PR @saurabhkoshatwar ! Could you please take a look at the integration test failure? I'm also thinking if we could add any more integration/unit tests to verify this change. For instance to see if there could still be any validation failures while actually using hyphenated parameters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #580
Summary
Details