Open
Conversation
Contributor
|
Thanks for the PR @rahulpinto19! QQ: Could you include your verification steps? Specifically, it would be great to see the reproduction scripts and their outputs to confirm the fix works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem:
If a tool description has an extra newline at the end, the system creates a "triple newline" gap before the arguments. This breaks the logic that LangChain uses to "clean" the prompt, causing the parameters to be listed twice.
The Fix:
I added .rstrip() to the description. This cleans up the extra spacing and ensures the gap is always exactly two newlines.
fixes: googleapis/genai-toolbox#1327