Skip to content

chore: cleanup session pool #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surbhigarg92 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: cleanup session pool #2503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9fcaa
chore: cleanup session pool
surbhigarg92 Jan 13, 2026
251ab4f
unskip tests for afe connectivity
surbhigarg92 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
369 changes: 7 additions & 362 deletions observability-test/database.ts
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion observability-test/observability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const {
SEMATTRS_DB_NAME,
SEMATTRS_DB_SQL_TABLE,
SEMATTRS_DB_STATEMENT,
SEMATTRS_DB_SYSTEM,
SEMATTRS_EXCEPTION_MESSAGE,
} = require('@opentelemetry/semantic-conventions');

Expand Down
218 changes: 0 additions & 218 deletions observability-test/session-pool.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions observability-test/spanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ describe('EndToEnd', async () => {
'Begin Transaction',
'Transaction Creation Done',
...cacheSessionEvents,
'Using Session',
'Starting stream',
];
await verifySpansAndEvents(
Expand Down
3 changes: 0 additions & 3 deletions observability-test/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,9 +547,6 @@ describe('Transaction', () => {
});

it('no error with unset `id`', done => {
const expectedError = new Error(
'Transaction ID is unknown, nothing to rollback.',
);
delete transaction.id;

transaction.rollback(err => {
Expand Down
1 change: 1 addition & 0 deletions samples/batch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.

'use strict';
//test

async function createAndExecuteQueryPartitions(
instanceId,
Expand Down
Loading
Loading