Skip to content

chore: replace old nodejs teams with cloud-sdk-nodejs-team #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suztomo wants to merge 1 commit into from
Closed

chore: replace old nodejs teams with cloud-sdk-nodejs-team #2518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax


# Unless specified, the jsteam is the default owner for nodejs repositories.
* @googleapis/spanner-client-libraries-nodejs @googleapis/jsteam
# Unless specified, the googleapis/cloud-sdk-nodejs-team is the default owner for nodejs repositories.
Copy link

@gemini-code-assist gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the syntax used for teams in CODEOWNERS files, it would be clearer to include the @ prefix for the team name in this comment.

# Unless specified, the @googleapis/cloud-sdk-nodejs-team is the default owner for nodejs repositories.

* @googleapis/spanner-client-libraries-nodejs @googleapis/cloud-sdk-nodejs-team
Copy link

@gemini-code-assist gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a good practice to end files with a newline character. This prevents potential issues with file concatenation and some command-line tools that process text files.

*     @googleapis/spanner-client-libraries-nodejs @googleapis/cloud-sdk-nodejs-team

Loading