feat: call fetchToken in startChat to speed up the first message response #504
+126
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: startChat is now async in order to await fetchToken
product-auto-label
bot
added
the
api: aiplatform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to the gemini SDK, in the Vertex SDK, sending the first message is really slow, due to having to retreive the auth token. I'm not sure why this is slow, but this PR adds the fetchToken call to the
ChatSession.startChatmethod. This makesstartChatslow, but results in a nicer UX (IMO) because the user waits for a chat ui to load/initialize instead of waiting for their first response.BREAKING CHANGE:
startChatis now async in order to await fetching the auth token