Skip to content

fix: incorrect return type annotation for Message.to_dict #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 2 commits into from
Jan 21, 2025
Merged

fix: incorrect return type annotation for Message.to_dict #516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f7f1a
fix: incorrect return type annotation for Message.to_dict
bricker Jan 17, 2025
7f4c894
Merge branch 'main' into bcr/2501/fix-to_dict-return-type
parthea Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions proto/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import collections.abc
import copy
import re
from typing import List, Optional, Type
from typing import Any, Dict, List, Optional, Type
import warnings

import google.protobuf
Expand Down Expand Up @@ -558,7 +558,7 @@ def to_dict(
including_default_value_fields=None,
float_precision=None,
always_print_fields_with_no_presence=None,
) -> "Message":
) -> Dict[str, Any]:
"""Given a message instance, return its representation as a python dict.

Args:
Expand Down
Loading