fix: handle boolean MCP schema leaves#2563
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
he-yufeng
force-pushed
the
fix/mcp-boolean-additional-properties
branch
from
da0766d to
08ceb27
Compare
Contributor
Author
|
Rebased this branch onto current Validation:
|
he-yufeng
force-pushed
the
fix/mcp-boolean-additional-properties
branch
from
08ceb27 to
9b83860
Compare
he-yufeng
force-pushed
the
fix/mcp-boolean-additional-properties
branch
from
9b83860 to
9dd5f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2393.
_filter_to_supported_schema()recursively filters MCP JSON Schema input before converting it to a Gemini tool declaration. JSON Schema allows boolean values foradditionalProperties, and FastMCP/Pydantic schemas commonly emitadditionalProperties: false. The current recursion assumes every nested schema value is a dict and calls.items(), so those valid schemas crash withAttributeError: 'bool' object has no attribute 'items'.This keeps scalar schema leaves as-is before recursing into dictionaries, then adds MCP conversion coverage for a nested object with
additionalProperties: false.To verify
UNITTEST_ON_FORGE=1 python -m pytest google/genai/tests/mcp/test_mcp_to_gemini_tools.py -qpython -m py_compile google/genai/_mcp_utils.py google/genai/tests/mcp/test_mcp_to_gemini_tools.py