fix: pin working google-cloud-spanner version#729
Closed
waltaskew wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix: pin working google-cloud-spanner version#729waltaskew wants to merge 1 commit intogoogleapis:mainfrom
waltaskew wants to merge 1 commit intogoogleapis:mainfrom
Conversation
mockserver tests are failing with google-cloud-spanner==3.56.0 The request sequence these tests rely on has gone from `[BatchCreateSessionsRequest, BeginTransactionRequest, ExecuteSqlRequest, CommitRequest]` to `[BatchCreateSessionsRequest, CreateSessionRequest, BeginTransactionRequest, ExecuteSqlRequest, CommitRequest]` It's not clear to me if this is an actual bug or just an issue with the tests. issue: googleapis#728
product-auto-label
bot
added
the
api: spanner
Contributor
|
The cause of this is that the Spanner Python client has switched from using a session pool to using a single multiplexed session for all operations. The tests have been updated to reflect this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mockserver tests are failing with google-cloud-spanner==3.56.0 The request sequence these tests rely on has gone from
[BatchCreateSessionsRequest, BeginTransactionRequest, ExecuteSqlRequest, CommitRequest]to
[BatchCreateSessionsRequest, CreateSessionRequest, BeginTransactionRequest, ExecuteSqlRequest, CommitRequest]It's not clear to me if this is an actual bug or just an issue with the tests.
issue: #728