Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Allow third party repository locations#177

Open
isorna wants to merge 4 commits intogooglearchive:masterfrom
isorna:master
Open

Allow third party repository locations#177
isorna wants to merge 4 commits intogooglearchive:masterfrom
isorna:master

Conversation

@isorna
Copy link
Copy Markdown

@isorna isorna commented Sep 18, 2015

Hi there,

I'm using polymer-element-catalog for generating our own project documentation, but there seems that source code's link always go to github, and we're using stash. I'd modified this file in order to allow full http links, instead of github relative repos.

I hope you like it, I think it'll help people like me to use their own repos.

Regards

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@isorna
Copy link
Copy Markdown
Author

isorna commented Sep 18, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@isorna
Copy link
Copy Markdown
Author

isorna commented Sep 18, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@carolirod
Copy link
Copy Markdown

+1

@shawncplus
Copy link
Copy Markdown

heh, already sent in this pull request two months ago #156

@froucher
Copy link
Copy Markdown

+1

1 similar comment
@recluising
Copy link
Copy Markdown

+1

@arthurevans
Copy link
Copy Markdown
Contributor

Pinging @frankiefu -- we have two PRs on this, can you PTAL?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... How did that change ever work? There is no global githubLink. Should that be this._ githubLink instead?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm sorry, I've like 3 different versions of this project, and pushed the wrong one. Fixed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it will match if http is in any part of the source url. Can you change it to make sure it matches only if it starts with http?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I hope now it's fixed. Thanks frankiefu.

@jariaspe
Copy link
Copy Markdown

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants