Skip to content

fix: code quality and safety improvements #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: code quality and safety improvements #2460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/pages/History.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ export default function History() {
method: "POST",
body: formData
});
const data = await response.json();
if (!response.ok) throw new Error("Request failed");
const data = await response.json();
toast({ title: "Success", description: data.message });
} catch (err: unknown) {
toast({ title: "Upload Error", description: err instanceof Error ? (err as Error).message : String(err), variant: "destructive" });
Expand Down
4 changes: 2 additions & 2 deletions server/controllers/assessments.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ export const getAssessmentById = async (req: Request, res: Response) => {
try {
const id = parseInt(req.params.id as string, 10);

if (isNaN(id) || id <= 0) {
if (Number.isNaN(id) || id <= 0) {
return res.status(400).json({ message: "Invalid assessment ID." });
}

Expand Down Expand Up @@ -520,7 +520,7 @@ export const deleteAssessment = async (req: Request, res: Response) => {
try {
const id = parseInt(req.params.id as string, 10);

if (isNaN(id) || id <= 0) {
if (Number.isNaN(id) || id <= 0) {
return res.status(400).json({ message: "Invalid assessment ID." });
}

Expand Down
2 changes: 1 addition & 1 deletion server/middleware/requireAssessmentAccess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export async function requireAssessmentAccess(
try {
const id = parseInt(req.params.id as string, 10);

if (isNaN(id) || id <= 0) {
if (Number.isNaN(id) || id <= 0) {
return res.status(400).json({ message: "Invalid assessment ID." });
}

Expand Down
12 changes: 6 additions & 6 deletions server/repositories/assessment.repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,12 @@ export class AssessmentRepository {
filters.push(lte(assessments.age, maxAge));
}

if (startDate && !isNaN(Date.parse(startDate))) {
if (startDate && !Number.isNaN(Date.parse(startDate))) {
const parsedStart = parseDateFilter(startDate);
if (parsedStart) filters.push(gte(assessments.createdAt, parsedStart));
}

if (endDate && !isNaN(Date.parse(endDate))) {
if (endDate && !Number.isNaN(Date.parse(endDate))) {
const parsedEnd = parseDateFilter(endDate);
if (parsedEnd) {
parsedEnd.setUTCHours(23, 59, 59, 999);
Expand Down Expand Up @@ -451,11 +451,11 @@ export class AssessmentRepository {
if (createdBy) {
filters.push(eq(assessments.createdBy, createdBy));
}
if (startDate && !isNaN(Date.parse(startDate))) {
if (startDate && !Number.isNaN(Date.parse(startDate))) {
const parsedStart = parseDateFilter(startDate);
if (parsedStart) filters.push(gte(assessments.createdAt, parsedStart));
}
if (endDate && !isNaN(Date.parse(endDate))) {
if (endDate && !Number.isNaN(Date.parse(endDate))) {
const parsedEnd = parseDateFilter(endDate);
if (parsedEnd) {
parsedEnd.setUTCHours(23, 59, 59, 999);
Expand Down Expand Up @@ -600,11 +600,11 @@ export class AssessmentRepository {
if (params.maxHba1c !== undefined) filters.push(lte(assessments.hba1cLevel, params.maxHba1c));
if (params.minGlucose !== undefined) filters.push(gte(assessments.bloodGlucoseLevel, params.minGlucose));
if (params.maxGlucose !== undefined) filters.push(lte(assessments.bloodGlucoseLevel, params.maxGlucose));
if (params.startDate && !isNaN(Date.parse(params.startDate))) {
if (params.startDate && !Number.isNaN(Date.parse(params.startDate))) {
const parsedStart = parseDateFilter(params.startDate);
if (parsedStart) filters.push(gte(assessments.createdAt, parsedStart));
}
if (params.endDate && !isNaN(Date.parse(params.endDate))) {
if (params.endDate && !Number.isNaN(Date.parse(params.endDate))) {
const parsedEnd = parseDateFilter(params.endDate);
if (parsedEnd) {
parsedEnd.setUTCHours(23, 59, 59, 999);
Expand Down
2 changes: 1 addition & 1 deletion server/utils/csvSanitizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function sanitizeCsvCell(value: unknown): string {
}

const trimmed = text.trim();
if (trimmed !== "" && !isNaN(Number(trimmed))) {
if (trimmed !== "" && !Number.isNaN(Number(trimmed))) {
return text;
}

Expand Down
Loading