Skip to content

fix: resolve 4 bugs in Clinical-Insight-Engine - #2464

Open
saurabhhhcodes wants to merge 1 commit into
gopaljilab:mainfrom
saurabhhhcodes:fix/Clinical-Insight-Engine-96409
Open

fix: resolve 4 bugs in Clinical-Insight-Engine#2464
saurabhhhcodes wants to merge 1 commit into
gopaljilab:mainfrom
saurabhhhcodes:fix/Clinical-Insight-Engine-96409

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Description

This PR fixes real bugs found in the codebase:

  • Fixed default sort: .sort() coerces elements to strings, so [10, 9, 2] sorts as [10, 2, 9]; numeric comparator sorts correctly.
  • Added explicit radix to parseInt: without 10, strings like '0x1F' or '08' parse in unintended bases.
  • Added explicit radix to parseInt: without 10, strings like '0x1F' or '08' parse in unintended bases.
  • Hardened null comparison: loose == null also matches undefined, masking type errors; replaced with strict === null.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #2463

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the gopaljilab's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the type:security Vulnerability fixes or security-related enhancements. label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:security Vulnerability fixes or security-related enhancements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant