Update decoder to not panic when there are unexported fields in a different package.#236
Open
rishavm47 wants to merge 1 commit intogorilla:mainfrom
Open
Update decoder to not panic when there are unexported fields in a different package.#236rishavm47 wants to merge 1 commit intogorilla:mainfrom
rishavm47 wants to merge 1 commit intogorilla:mainfrom
Conversation
Signed-off-by: Rishav Maheshwari <rishavm47@gmail.com>
Author
|
@zak905 Please review. |
|
Can we update the encoder to ignore unexported fields as well? That's the standard behavior for most encoders I know of. |
Contributor
|
@rishavm47 sorry I am just seeing this now, I don't have merge rights over the repo, the maintainers seems to have abandoned the repo for a while now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fix a bug to make this backward compatible with v1.2.1
Related Tickets & Documents
#234
Added/updated tests?
Run verifications and test
make verifyis passing (failing the same like it fails formainbranch)make testis passing