Fix hidden and expired items in recommendation results#1192
Open
eyupcanakman wants to merge 2 commits intogorse-io:masterfrom
Open
Fix hidden and expired items in recommendation results#1192eyupcanakman wants to merge 2 commits intogorse-io:masterfrom
eyupcanakman wants to merge 2 commits intogorse-io:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
+ Coverage 72.72% 72.74% +0.01%
==========================================
Files 88 88
Lines 16258 16333 +75
==========================================
+ Hits 11824 11881 +57
- Misses 3233 3242 +9
- Partials 1201 1210 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhenghaoz
requested changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #764
Summary
Recommendation results could still include hidden items and items older than
item_ttl.Filter cached and fallback recommendation results against current item metadata, and keep scanning past filtered entries so valid items still fill the response. Keep cache-only IDs without item rows unchanged.
Testing
go test ./logics ./server ./worker -count=1go test ./... -run '^$' -count=1