Skip to content

Workflow action version updates #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmattheis merged 2 commits into from
Dec 1, 2024
Merged

Workflow action version updates #389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f10d9c7
ci: bump action versions
cyb3rko Nov 25, 2024
2b4b7d8
ci: use temurin
jmattheis Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ jobs:
name: Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
Copy link
Member

@jmattheis jmattheis Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why zulu and not temurin?

Copy link
Contributor Author

@cyb3rko cyb3rko Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the same one as before:
https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.md

You can change it if you want:
https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions

Copy link
Member

@jmattheis jmattheis Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, do you have a preference? I think temurin is more open, as it's maintained eclipse?

Copy link
Contributor Author

@cyb3rko cyb3rko Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://whichjdk.com/, temurin sounds good

Copy link
Contributor Author

@cyb3rko cyb3rko Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly use Zulu or SapMachine, but only because they just work. I never bothered to change it for my projects.

Copy link
Member

@jmattheis jmattheis Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then let's go with temurin, if the build succeeds (:.

java-version: 17
- if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
run: ./gradlew build --stacktrace
Expand Down