[DEVOPS-301] Make testing services optional.#117
Open
barbun wants to merge 2 commits intogovCMS:developfrom
Open
[DEVOPS-301] Make testing services optional.#117barbun wants to merge 2 commits intogovCMS:developfrom
barbun wants to merge 2 commits intogovCMS:developfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
docker-compose.yml:138
- The instructions in the commented out block imply that both test and chrome services should be enabled together. Please add guidance or a note indicating that uncommenting only one of these may lead to dependency issues since the chrome service depends on the test service.
# Uncomment to enable testing.
.ahoy.yml:9
- Switching the wait command from the 'test' container to the 'cli' container is a critical change. Please verify that the cli container is properly configured and ready to handle this waiting logic, ensuring it truly replaces the original behavior.
docker compose exec -T cli dockerize -wait tcp://mariadb:3306 -timeout 2m &&
.ahoy.yml:29
- Ensure that using the 'cli' container in place of the removed 'test' service does not negatively affect the expected timing or initialization dependencies in your pipeline.
docker compose exec -T cli dockerize -wait tcp://mariadb:3306 -timeout 2m &&
steveworley
approved these changes
May 20, 2025
|
Just noting here that this relies on adding |
sonnykt
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The scaffold ships with two container definitions that increase the start time of the docker compose stack. These are used only by a handful of customers. To reduce the pipeline consumption usage by projects, we should make these opt-in only.
Proposed solution
Comment out the services and adjust the build commands.