This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Control and radio input groups#548
Open
sukhrajghuman wants to merge 5 commits into
Open
Conversation
Contributor
|
Hmmm i'm not too sure on this one, the components were pretty clean before and maybe we are now supporting too much? I assume most people would write code to handle this state themselves ( especially in forms )? Also this branch has unmerged commits 😕 |
Contributor
Author
|
Will discuss the option of having radio and checkbox list react components |
sukhrajghuman
added
submitted by user
alex-page
changed the title
azerella
force-pushed
the
develop
branch
5 times, most recently
from
March 1, 2019 00:52
c343bcc to
1b6a5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #544
Will need to update docs on design system site also to reflect this.
Basically made RadioList and CheckboxList components which control the state of the checked items and has callbacks into the parent component